Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates Ensembleable #2043

Merged
merged 3 commits into from Sep 29, 2022
Merged

Creates Ensembleable #2043

merged 3 commits into from Sep 29, 2022

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Sep 28, 2022

This creates a new interface Ensembleable to be used for translator outputs that can be ensembled or averaged together. The interface will later be used as part of workflows within DJL Serving.

This creates a new interface Ensembleable to be used for translator outputs that
can be ensembled or averaged together. The interface will later be used as part
of workflows within DJL Serving.
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Base: 72.08% // Head: 69.72% // Decreases project coverage by -2.36% ⚠️

Coverage data is based on head (f070c39) compared to base (bb5073f).
Patch coverage: 68.82% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2043      +/-   ##
============================================
- Coverage     72.08%   69.72%   -2.37%     
- Complexity     5126     5979     +853     
============================================
  Files           473      599     +126     
  Lines         21970    26525    +4555     
  Branches       2351     2883     +532     
============================================
+ Hits          15838    18494    +2656     
- Misses         4925     6646    +1721     
- Partials       1207     1385     +178     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java 76.00% <ø> (ø)
...rc/main/java/ai/djl/modality/cv/output/Joints.java 71.42% <ø> (ø)
.../main/java/ai/djl/modality/cv/output/Landmark.java 100.00% <ø> (ø)
...main/java/ai/djl/modality/cv/output/Rectangle.java 72.41% <0.00%> (ø)
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <0.00%> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
.../cv/translator/InstanceSegmentationTranslator.java 0.00% <0.00%> (-86.59%) ⬇️
...nslator/InstanceSegmentationTranslatorFactory.java 7.14% <0.00%> (-11.04%) ⬇️
.../cv/translator/SemanticSegmentationTranslator.java 0.00% <0.00%> (ø)
... and 512 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frankfliu
Copy link
Contributor

I updated your PR, please take a look.

@zachgk
Copy link
Contributor Author

zachgk commented Sep 29, 2022

It mostly looks good. I'm glad you found a way to do it without needing the casting. I did add back a test for mismatched class names. I think that especially when using imported model zoos, the chances of issues here are likely and this should help prevent those issues from being hard to detect or debug

@zachgk zachgk merged commit 53022b9 into deepjavalibrary:master Sep 29, 2022
@zachgk zachgk deleted the ensembleable branch September 29, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants