LightGBM inference result matches input type #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Nov 4, 2022
| ByteBuffer bb = ByteBuffer.allocateDirect(length * 4); | ||
| FloatBuffer wrapped = bb.asFloatBuffer(); | ||
| for (int i = 0; i < length; i++) { | ||
| wrapped.put((float) lightgbmlib.doubleArray_getitem(outBuffer, i)); |
There was a problem hiding this comment.
Can we call lightgbm.floatArray_getitem()?
There was a problem hiding this comment.
The behavior of the lightgbm engine is to always return a double array and this is the utility provided by lightgbm to get from a JNI double[] data structure. So if we want to return a float[], we need to convert it from double to float
This makes the LightGBM inference return the same as the input type (either float32 or float64) rather than always returning float64 per the API. In addition, it adds a bit nicer handling for creation from a Buffer in that it will also accept either a FloatBuffer or a DoubleBuffer.
Codecov ReportBase: 72.08% // Head: 71.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2129 +/- ##
============================================
- Coverage 72.08% 71.49% -0.60%
- Complexity 5126 6315 +1189
============================================
Files 473 624 +151
Lines 21970 27871 +5901
Branches 2351 3009 +658
============================================
+ Hits 15838 19927 +4089
- Misses 4925 6480 +1555
- Partials 1207 1464 +257
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
frankfliu
approved these changes
Nov 6, 2022
zachgk
added a commit
to zachgk/djl
that referenced
this pull request
Nov 8, 2022
This makes the LightGBM inference return the same as the input type (either float32 or float64) rather than always returning float64 per the API. In addition, it adds a bit nicer handling for creation from a Buffer in that it will also accept either a FloatBuffer or a DoubleBuffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the LightGBM inference return the same as the input type (either float32 or float64) rather than always returning float64 per the API.
In addition, it adds a bit nicer handling for creation from a Buffer in that it will also accept either a FloatBuffer or a DoubleBuffer.