[api] Allows to use relative jar uri for cache folder name #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3026 +/- ##
=========================================
Coverage 72.30% 72.30%
- Complexity 7294 7295 +1
=========================================
Files 722 722
Lines 32508 32512 +4
Branches 3395 3396 +1
=========================================
+ Hits 23506 23509 +3
- Misses 7382 7385 +3
+ Partials 1620 1618 -2 ☔ View full report in Codecov by Sentry. |
zachgk
reviewed
Mar 12, 2024
| String fileName = path.toFile().getName(); | ||
| if (FilenameUtils.isArchiveFile(fileName)) { | ||
| fileName = FilenameUtils.getNamePart(fileName); | ||
| } | ||
|
|
||
| return new JarRepository(name, uri, fileName, queryString); | ||
| return new JarRepository(name, uri, fileName, jarUri); |
There was a problem hiding this comment.
Is the name real uri or jarUri? Also, can we document this somewhere?
There was a problem hiding this comment.
Renamed to realUri and added comments
zachgk
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3025
Description
Brief description of what this PR is about