fix(type): correctly report invalid date types

fixes #412
deepkit · Feb 17, 2023 · 10868e4 · marcj · Feb 20, 2023 · marcj
1 parent 0f4cf65
commit 10868e4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/type/src/serializer.ts b/packages/type/src/serializer.ts
@@ -1987,7 +1987,7 @@ export class Serializer {
 
                 // when an object with primary key is given e.g. {id: 1} we treat it as
                 // reference and assign an instance of Reference to the property.
-                const l: string[] = [`getObjectKeysSize(${state.accessor}) === ${reflection.getPrimaries().length}`];
+                const l: string[] = [`${reflection.getPrimaries().length} > 0 && getObjectKeysSize(${state.accessor}) === ${reflection.getPrimaries().length}`];
                 for (const pk of reflection.getPrimaries()) {
                     l.push(`${JSON.stringify(pk.name)} in ${state.accessor}`);
                 }
@@ -2139,7 +2139,7 @@ export class Serializer {
 
         this.typeGuards.getRegistry(1).registerClass(Set, typeGuardClassSet);
         this.typeGuards.getRegistry(1).registerClass(Map, typeGuardClassMap);
-        this.typeGuards.getRegistry(1).registerClass(Date, (type, state) => state.addSetter(`${state.accessor} instanceof Date`));
+        this.typeGuards.getRegistry(1).registerClass(Date, (type, state) => state.addSetterAndReportErrorIfInvalid('type', 'No a Date', `${state.accessor} instanceof Date`));
         this.typeGuards.getRegistry(0.5).registerClass(Date, (type, state) => {
             state.addSetter(`'string' === typeof ${state.accessor} && new Date(${state.accessor}).toString() !== 'Invalid Date'`);
         });

diff --git a/packages/type/tests/validation.spec.ts b/packages/type/tests/validation.spec.ts
@@ -290,3 +290,11 @@ test('class with statics', () => {
     expect(validate<PilotId>({value: 34})).toEqual([]);
     expect(validate<PilotId>({value: '33'})).toEqual([{code: 'type', message: 'Not a number', path: 'value'}]);
 });
+
+test('date', () => {
+    class Account {
+        public name!: string;
+        public createdAt!: Date;
+    }
+    expect(validate<Account>({name: "jack", createdAt: 'asd'})).toEqual([{code: 'type', message: 'No a Date', path: 'createdAt'}]);
+});