refactor(type): return all errors when validating array

Instead of just first as previously #565 (comment)
deepkit · May 14, 2024 · 4f12c65 · 4f12c65
1 parent d89e3d3
commit 4f12c65
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/type/src/serializer.ts b/packages/type/src/serializer.ts
@@ -1502,7 +1502,6 @@ export function typeGuardArray(elementType: Type, state: TemplateState) {
             ${v} = iterableSize(${state.accessor}) === 0;
             for (const ${item} of ${state.accessor}) {
                 ${executeTemplates(state.fork(v, item).extendPath(new RuntimeCode(i)), elementType)}
-                if (!${v}) break;
                 ${i}++;
             }
          } else if (${state.isValidation()}) {

diff --git a/packages/type/tests/validation.spec.ts b/packages/type/tests/validation.spec.ts
@@ -354,3 +354,17 @@ test('speed', () => {
     // but inline vs ref must not be slower than 2.5 times.
     // expect(ratio).toBeLessThan(2.5);
 });
+
+test('array with multiple errors', () => {
+    interface Skill {
+        level: number & Positive;
+    }
+
+    const errors = validate<Array<Skill>>([{level: -1}, {level: -1}]);
+    console.log(errors);
+
+    expect(errors).toEqual([
+        {code: 'positive', message: 'Number needs to be positive', path: '0.level', value: -1},
+        {code: 'positive', message: 'Number needs to be positive', path: '1.level', value: -1}
+    ]);
+});