Use cross-environment globalThis to access the global object.
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcj
reviewed
Feb 26, 2023
| @@ -347,7 +353,7 @@ function serialize(type: Type, state: SerializerState): SerializedTypeReference | |||
| } | |||
|
|
|||
| const classType = getClassName(type.classType); | |||
| const globalObject: boolean = global && (global as any)[classType] === type.classType; | |||
| const globalObject: boolean = envGlobal && (envGlobal as any)[classType] === type.classType; | |||
There was a problem hiding this comment.
can we not just define const envGlobal: any = ... and then omit this type cast?
|
Cool, thank you @T-Hugs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Prefers using
globalThisto access the global object, which is standard across node and browser environments. I'm not sure what versions of browsers/node Deepkit is obligated to support, so we may be able to drop theenvGlobalvariable and just go withglobalThiseverywhere.Relinquishment of Rights
Please mark following checkbox to confirm that you relinquish all rights of your changes: