PDF Export with Embedded SVG

[jdgwf]

I've created the following test SVG (I've simplified this ugly example immensely after discovering this issue):

SVG Preview Screenshot:

PDF Render:

Will paste my (again, ugly) test SVG code below.

What appears to be happening:
svglib is trying to use one of the embedded SVG dimensions as the parent document dimension.

[jdgwf]

Here's the svg as a txt file:
drawing.svg.txt

[claudep]

Yes, it's known that embedding SVGs is currently buggy (this was revealed by the Slovenia.svg flag output in the current test suite).

[jdgwf]

I apologize for the duplicate ticket then. Any suggestions where to look to help squash this bug? I'll be mulling over the code to help patch this :)

[claudep]

No need to apologize, there was no properly-named ticket about this until now.
The problem is probably around the renderSVG method, which assumes it is always the top-most node of the file.
https://github.com/deeplook/svglib/blob/master/svglib/svglib.py#L526

[jdgwf]

Ok I have a working Alpha quality patch - testing now

[jdgwf]

Looks like I may have to open a pull request once I'm more sure ;)

[claudep]

Show us the code, dude :-)

[jdgwf]

Scaling needs to be fixed...

[jdgwf]

Here are the two functions I've applied code to class SvgRenderer:

def __init__(self, path=None,color_converter=None):
    self.attrConverter = Svg2RlgAttributeConverter(color_converter=color_converter)
    self.shape_converter = Svg2RlgShapeConverter(path,self.attrConverter)
    self.handled_shapes = self.shape_converter.get_handled_shapes()
    self.definitions = {}
    self.waiting_use_nodes = defaultdict(list)
    self.box = Box(x=0, y=0, width=0, height=0)
    self.parent_node = True

def renderSvg(self, node):
    getAttr = node.getAttribute
    width, height = map(getAttr, ("width", "height",))
    width, height = map(self.attrConverter.convertLength, (width, height))

    x, y = map(getAttr, ("x", "y",))
    x, y = map(self.attrConverter.convertLength, (x, y))

    viewBox = getAttr("viewBox")
    print( width, height, x, y, self.parent_node, viewBox )

    if viewBox:
        viewBox = self.attrConverter.convertLengthList(viewBox)
        if self.parent_node:
            self.box = Box(*viewBox)
    else:
        if self.parent_node:
            self.box = Box(0, 0, width, height)
    self.parent_node = False

    group = Group()
    for child in node.getchildren():
        self.renderNode(child, group)
    transform = ""
    if x or y:
        transform += " translate(%s, %s)" % (x or '0', y or '0')
    if transform:
        self.shape_converter.applyTransformOnGroup(transform, group)

    return group

[jdgwf]

translate works, but I have a scale issue to work through. Still learning the class/object.

[jdgwf]

Still hacky. Here's the code that's working on my fairly complex SVG:

def renderSvg(self, node):
    getAttr = node.getAttribute
    width, height = map(getAttr, ("width", "height",))
    width, height = map(self.attrConverter.convertLength, (width, height))

    x, y = map(getAttr, ("x", "y",))
    x, y = map(self.attrConverter.convertLength, (x, y))

    viewBox = getAttr("viewBox")

    childBox = None



    if viewBox:
        viewBox = self.attrConverter.convertLengthList(viewBox)
        if self.parent_node:
            self.box = Box(*viewBox)
        else:
            childBox = Box(*viewBox)
    else:
        if self.parent_node:
            self.box = Box(0, 0, width, height)
    self.parent_node = False

    group = Group()

    for child in node.getchildren():
        self.renderNode(child, group)
    transform = ""



    x_scale = 1
    y_scale = 1
    if childBox:
        print( "childBox", childBox )
        if childBox.height != height:
            y_scale = height /  childBox.height
        if childBox.width != width:
            x_scale = width /  childBox.width

    print( width, height, x, y, self.parent_node, viewBox, x_scale, y_scale )
    if x or y:
        transform += " translate(%s, %s)" % (x or '0', y or '0')

    if transform:
        self.shape_converter.applyTransformOnGroup(transform, group)

    group.scale(x_scale, y_scale )
    return group

[jdgwf]

Ignore the debug print(), of course ;)

[jdgwf]