Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python2 numerical relics and fix % formatting in logging #269

Merged
merged 4 commits into from Feb 4, 2021
Merged

Remove Python2 numerical relics and fix % formatting in logging #269

merged 4 commits into from Feb 4, 2021

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Feb 1, 2021

No description provided.

@deeplook
Copy link
Owner

deeplook commented Feb 1, 2021

Thanks! LGTM! Just nosey, did you run a tool for spotting the ints/floats? If so which one?

@eumiro
Copy link
Contributor Author

eumiro commented Feb 1, 2021

I just sought for int, float, looked at the literal numerals and watched my GeoPython 2021 talk :-)

Looks like you'll need to set the environment for Python 3.9 in AppVeyor to run it correctly. See https://www.appveyor.com/docs/windows-images-software/#python for different Visual Studio versions.

Copy link
Collaborator

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@deeplook
Copy link
Owner

deeplook commented Feb 3, 2021

Frankly, I don't see how to add a py39 environment for AppVeyor: https://ci.appveyor.com/project/deeplook/svglib. Maybe it's time to move to https://docs.github.com/en/actions/guides/building-and-testing-python?

@eumiro
Copy link
Contributor Author

eumiro commented Feb 3, 2021

Frankly, I don't see how to add a py39 environment for AppVeyor: https://ci.appveyor.com/project/deeplook/svglib. Maybe it's time to move to https://docs.github.com/en/actions/guides/building-and-testing-python?

Right, let's do it in #271

@eumiro eumiro mentioned this pull request Feb 3, 2021
@eumiro
Copy link
Contributor Author

eumiro commented Feb 3, 2021

Rebased onto GHA/Travis/Appveyor changes, so the Python versions migration touches PyPI classifiers only. The removal of Python2 int/float relics and proper % log formatting have not been touched.

@eumiro eumiro changed the title Add Python 3.9 support, drop Python 3.5 support everywhere and modernize the code Remove Python2 numerical relics and fix % formatting in logging Feb 3, 2021
@claudep claudep merged commit 471bedf into deeplook:master Feb 4, 2021
@deeplook
Copy link
Owner

deeplook commented Feb 4, 2021

I have now deleted this project from https://ci.appveyor.com/account/deeplook/projects.

@eumiro eumiro deleted the py39 branch February 4, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants