Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect absolute coordinates for tspan #82

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Conversation

claudep
Copy link
Collaborator

@claudep claudep commented Apr 9, 2017

Fixes #81.

@jdugge
Copy link

jdugge commented Apr 9, 2017

That looks really good, thanks for the fast response! The conversion of the plot attached to #81 does indeed work much better now, however when converting the airbus.svg from the samples/misc directory, the second line of text ("Seating layout") gets lost with this commit.

The text/tspan tag in airbus.svg looks like this:

<text transform="matrix(0.9387 0 0 1 312.7847 24.2568)" style="fill:#CFCFCF;stroke:none; font-size:27.9868;letter-spacing:0em;">
<tspan x="0" y="0">AIRBUS A340</tspan>
<tspan x="-10.761" y="33.487">Seating Layout</tspan>
</text>

There's no y key in the text span, only a transform matrix.

airbus

@claudep
Copy link
Collaborator Author

claudep commented Apr 9, 2017

Nice catch, the patch needs improvement then...

@claudep
Copy link
Collaborator Author

claudep commented Apr 10, 2017

I pushed a fix. I appreciate your careful review!

@deeplook
Copy link
Owner

Thanks, I hope I can look at it this evening.

@deeplook deeplook merged commit e31497c into deeplook:master Apr 10, 2017
@deeplook
Copy link
Owner

Merged. Made me look at samples/W3C_SVG_12_TinyTestSuite/svg/text*.svg again, and have a big sigh at the missing features here...

@claudep
Copy link
Collaborator Author

claudep commented Apr 10, 2017

Thanks, I'll try to add basic support for em units soon.

@deeplook
Copy link
Owner

BTW, for @jdugge's sample file I'm getting overlapped text bits now near the origin like this:

issue82

@claudep
Copy link
Collaborator Author

claudep commented Apr 10, 2017

Yes, that is missing em unit support.

@claudep claudep deleted the 81 branch April 10, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants