Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'cannot define new methods on non-local type' error #1185

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Fix 'cannot define new methods on non-local type' error #1185

merged 5 commits into from
Aug 29, 2023

Conversation

ShouheiNishi
Copy link
Contributor

Fix for #1182

@ShouheiNishi ShouheiNishi marked this pull request as ready for review August 8, 2023 00:42
@jamietanna jamietanna added this to the v1.14.0 milestone Aug 29, 2023
@jamietanna jamietanna merged commit 90af95b into oapi-codegen:master Aug 29, 2023
4 checks passed
jamietanna added a commit that referenced this pull request Aug 29, 2023
@ShouheiNishi @jamietanna
Allow strict server to refer to external multipart definitions (#1185)
97f301d 
As flagged in #1212, our existing strict server functionality does not
handle the definition of external multipart type definitions.

We can therefore look up whether this is a multipart type and refer to
it accordingly.

Closes #1212.

Co-authored-by: Jamie Tanna <jamie@jamietanna.co.uk>
@ShouheiNishi ShouheiNishi deleted the issue1182 branch August 30, 2023 00:23
debuggerpk pushed a commit to breuHQ/oapi-codegen that referenced this pull request Sep 18, 2023
@ShouheiNishi @jamietanna @debuggerpk
Allow strict server to refer to external response definitions (oapi-c…
9260f75 
…odegen#1185)

As flagged in oapi-codegen#1182, our existing strict server functionality does not
handle the definition of external response definitions.

We can therefore determine if we're using an external package for the
definition and provide a type alias if required.

Closes oapi-codegen#1182.

Co-authored-by: Jamie Tanna <jamie@jamietanna.co.uk>
debuggerpk pushed a commit to breuHQ/oapi-codegen that referenced this pull request Sep 18, 2023
@ShouheiNishi @jamietanna @debuggerpk
Allow strict server to refer to external multipart definitions (oapi-…
0ba5fd6 
…codegen#1185)

As flagged in oapi-codegen#1212, our existing strict server functionality does not
handle the definition of external multipart type definitions.

We can therefore look up whether this is a multipart type and refer to
it accordingly.

Closes oapi-codegen#1212.

Co-authored-by: Jamie Tanna <jamie@jamietanna.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ShouheiNishi @jamietanna