-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix external reference propagation #1203
base: main
Are you sure you want to change the base?
Conversation
9490141
to
4fb2fe3
Compare
4fb2fe3
to
efec490
Compare
efec490
to
47fc644
Compare
This PR fixes an issue which we also face. @jamietanna what do you think about merging it? |
Thanks for this - we'll try and get it into the v1.16.0 release, which should be some time in October - things are a bit busy over the next few weeks so not sure how much of my free time I'll be able to give to oapi-codegen - hoping that at some point I can have enough GitHub sponsors to be able to dedicate a full day a week to Open Source! |
@ShouheiNishi @bartsmykla mind checking if the changes in #1389 have solved this for you? |
No. |
To confirm, the fix from #1389 hasn't solved all the external reference issues you're affected by? |
Yes. |
Unfortunately I cannot test it now as we reworked our flow to overcome this issue (we are cloning external dependencies and combining them in a one file then referencing int locally), but thank you for looking into this! |
What about #1253 that had this issue as a requirement? |
At least there are still issues like the test cases in this pull request. |
Fix for #1202