Bump Iris to remove Go 1.21 dependency #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the upgrade to Go 1.21, the Go toolchain now requires the `go` directive to match the maximum Go version in use in dependencies. This leads to any transitive dependency on Iris to result in a requirement of the consuming project moving to Go 1.21. We can upgrade Iris to a version that has downgraded the Go 1.21 requirement. We will pin to the latest commit on HEAD until v12.2.6 is released. Closes #1221.
jamietanna
force-pushed
the
chore/iris
branch
from
5ceee2a
to
aa081b4
Compare
jamietanna
changed the title
jamietanna
force-pushed
the
chore/iris
branch
from
aa081b4
to
62c25ef
Compare
As part of the upgrade to Go 1.21, the Go toolchain now requires the `go` directive to match the maximum Go version in use in dependencies. This leads to any transitive dependency on this library to result in a requirement of the consuming project moving to Go 1.21. Although in a lot of cases this may not be as problematic, it forces consumers to migrate, which we don't need to do in this case. As noted in #1221, dependencies on Fiber and Iris have caused Go toolchain changes due to be required, which then requires consumers to do the same. By making sure we build across both the current venison and the next version of Go - taking care to only support the two major Go versions in use by the Go team - we can hopefully pick up on issues like this sooner, albeit #1221 was raised super speedily! This is a slightly more complex setup than just specifying the version manually, but to avoid the risk of not updating it in all the places, we can at a minimum use the `go.mod` version for the current targeted version. We can make sure to not `fail-fast` so we can see each of the builds' results, instead of only seeing the first to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the upgrade to Go 1.21, the Go toolchain now requires the
godirective to match the maximum Go version in use in dependencies.This leads to any transitive dependency on Iris to result in a
requirement of the consuming project moving to Go 1.21.
We can upgrade Iris to a version that has downgraded the Go 1.21
requirement.
Closes #1221.