Use non-deprecated function names for oapi-codegen/runtime #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of oapi-codegen/runtime v1.1.0, we renamed these for common initialisms and deprecated the existing methods, which means this may show up as a warning in IDEs or tooling.
jamietanna
force-pushed
the
defect/replace-deprecated-strictnethttp-funcs
branch
from
4690f5a
to
ffe2282
Compare
jamietanna
changed the title
jamietanna
changed the title
|
Thanks very much @cimitan! Yeah this was due to the oapi-codegen/runtime library's https://github.com/oapi-codegen/runtime/releases/tag/v1.1.0 release, and we'd not come back to update here. Thanks for the fix, I've also added the other initialism we updated, and regenerated all the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed linting was failing in a project of mine and that was due to deprecated packages being referenced. I assume this could be a leftover / oversight from v2.0.0
I did not run tests to make sure other bits are not being broken by this change, but it looked safe to me at first.
Thanks