Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checks for unexpected reference depth #1392

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Remove checks for unexpected reference depth #1392

wants to merge 5 commits into from

Conversation

jamietanna
Copy link
Member

  • Remove checks for unexpected reference depth
  • Add test case for reference depth checks

Closes #1348.

@jamietanna
Remove checks for unexpected reference depth
c775a79 
In my opinion, this check doesn't seem to be providing much value, and
we've got a few folks requesting this be disabled.

Instead of gating this behind a feature flag, we'll just remove it.

Closes #1348.
@jamietanna
Add test case for reference depth checks
2327423 
For #1348.
@jamietanna jamietanna marked this pull request as draft December 18, 2023 17:04
@jamietanna
Copy link
Member Author

Requires we actually inspect what's at that path and reference that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected reference depth
1 participant
@jamietanna