Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cmd): Use os.Exit(1) only from main() #1398

Merged
merged 1 commit into from
Jan 23, 2024
Merged

refactor(cmd): Use os.Exit(1) only from main() #1398

merged 1 commit into from
Jan 23, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Dec 20, 2023 •
edited

This PR refactors newConfigFromOldConfig to return error instead of just exiting. This improves readability.

@jamietanna jamietanna self-requested a review January 10, 2024 11:24
jamietanna
jamietanna approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jamietanna jamietanna added the bug Something isn't working label Jan 23, 2024
@jamietanna jamietanna merged commit d326c01 into oapi-codegen:master Jan 23, 2024
8 checks passed
@jamietanna jamietanna changed the title refactor(cmd): Use os.Exit(1) only from main() refactor(cmd): Use os.Exit(1) only from main() Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamietanna jamietanna jamietanna approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @jamietanna