Type aliasing #232
Merged
Type aliasing #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| {{range .}}{{$opid := .OperationId}} | |||
| {{range .TypeDefinitions}} | |||
| // {{.TypeName}} defines parameters for {{$opid}}. | |||
| type {{.TypeName}} {{.Schema.TypeDecl}} | |||
| type {{.TypeName}} {{if and (opts.AliasTypes) (.CanAlias)}}={{end}} {{.Schema.TypeDecl}} | |||
There was a problem hiding this comment.
if opts.AliasTypes=faalse or .CanAlias=false, you will generate an empty type alias, no?
type TypeName
There was a problem hiding this comment.
If one of them is false, the type will be
type TypeName .Schema.TypeDecl
else it will be
type TypeName = .Schema.TypeDecl
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
* Add aliasable types logic and option * Update templates * Re-generate examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types are unnecessary wrapped, for example
which lengthens the code needed to create and handle such types.
I added an option, called
-alias-types, that changes all types satisfying:This change is