Fixes issue with dynamically created array of pointers with cffi #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
helm_values_files
is meant to be an array of pointers. Those pointers are references to strings which are helm values files to use in the golang code. As of now, I've gotten lucky that the bytes weren't freed any faster. I noticed that once I hit a string over 96 bytes that I was getting errors in the golang code saying it couldn't find the file which seems to no longer be properly encoded.Because the array of pointers in being dynamically created, I used the recommendation from the cffi docs and created a dict to hold pointer references so the data is not prematurely garbage collected.