Skip to content

Commit

Permalink
Merge pull request #1411 from hongriTianqi/contribute
Browse files Browse the repository at this point in the history
docs: skeleton of developer docs
  • Loading branch information
hongriTianqi committed Oct 24, 2022
2 parents 2ac9cb9 + 72d1b19 commit 687235a
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 18 deletions.
5 changes: 3 additions & 2 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Contributing to ABACUS

First of all, thank you for taking time making contributions to ABACUS!
This file provides a guideline for it.
First of all, thank you for taking time to make contributions to ABACUS!
This file provides the more technical guidelines on how to realize it.
For more non-technical aspects, please refer to the [ABACUS Contribution Guide](./community/contribution_guide.md)

## Table of Contents

Expand Down
16 changes: 16 additions & 0 deletions docs/community/contribution_guide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# ABACUS Contribution Guide

## Contribution Process

We welcome contributions from the open source community. The technical guide is provided in [Contributing to ABACUS](../CONTRIBUTING.md). Here is the basic contribution process:

- **Find out issues to work on.**
We assume you already have a good idea on what to do, otherwise the [issue tracker](https://github.com/deepmodeling/abacus-develop/issues) and [discussion](https://github.com/deepmodeling/abacus-develop/discussions) panel provide good starting points to find out what to work on and to get familiar with the project.

- **Approach the issue.**
It is suggested to [submit new issues](https://github.com/deepmodeling/abacus-develop/issues/new/choose) before coding out changes to involve more discussions and suggestions from development team. Refer to the technical guide in [Contributing to ABACUS](../CONTRIBUTING.md) when needed.

- **Open a pull request.** The ABACUS developers review the pull request (PR) list regularly. If the work is not ready, convert it to draft until finished, then you can mark it as "Ready for review". It is suggested to open a new PR through forking a repo and creating a new branch on you Github account. A new PR should include as much information as possible in `description` when submmited. Unittests or CI tests are required for new PRs.

- **Iterate the pull request.**
All pull requests need to be tested through CI before reviewing. A pull request might need to be iterated several times before accepted, so splitting a long PR into parts reduces reviewing difficulty for us.
3 changes: 3 additions & 0 deletions docs/community/faq.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Frequently Asked Questions

We collect frequently asked questions from issues/user feedbacks here.
3 changes: 0 additions & 3 deletions docs/faq.md

This file was deleted.

8 changes: 5 additions & 3 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ the developments and applications of novel machine-learning-assisted DFT methods

.. toctree::
:maxdepth: 2
:caption: Contributing to ABACUS
:caption: Community

community/contribution_guide
CONTRIBUTING

.. toctree::
:maxdepth: 2
:caption: FAQ
:glob:
:titlesonly:

community/faq
21 changes: 11 additions & 10 deletions docs/quick_start/hands_on.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,23 +77,23 @@ mpirun -np 2 abacus
The main output information is stored in the file `OUT.MgO/running_scf.log`, which starts with

```
WELCOME TO ABACUS
'Atomic-orbital Based Ab-initio Computation at UStc'
Website: http://abacus.ustc.edu.cn/
WELCOME TO ABACUS v3.0
'Atomic-orbital Based Ab-initio Computation at UStc'
Website: http://abacus.ustc.edu.cn/
Version: Parallel, in development
Processor Number is 2
Start Time is Sat Sep 24 13:06:35 2022
Start Time is Mon Oct 24 01:47:54 2022
------------------------------------------------------------------------------------
READING GENERAL INFORMATION
global_out_dir = OUT.MgO/
global_in_card = INPUT
pseudo_dir =
orbital_dir =
pseudo_dir =
orbital_dir =
DRANK = 1
DSIZE = 2
DCOLOR = 1
Expand All @@ -117,6 +117,7 @@ The main output information is stored in the file `OUT.MgO/running_scf.log`, whi
| in real and reciprocal space is also shown. |
| |
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
......
```
Expand Down

0 comments on commit 687235a

Please sign in to comment.