Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating atomic force in noncolliear and/or SOC case are needed #3233

Closed
1 of 14 tasks
hongriTianqi opened this issue Nov 20, 2023 · 3 comments · Fixed by #3933 or #4048
Closed
1 of 14 tasks

Calculating atomic force in noncolliear and/or SOC case are needed #3233

hongriTianqi opened this issue Nov 20, 2023 · 3 comments · Fixed by #3933 or #4048
Assignees
Labels
Feature Discussed The features will be discussed first but will not be implemented soon

Comments

@hongriTianqi
Copy link

hongriTianqi commented Nov 20, 2023

Background

Calculating atomic force in noncolliear and/or SOC case are needed in calculation of DeepSpin.

Describe the solution you'd like

Implement atomic force calculation in noncolliear and/or SOC calculations.

Task list only for developers

  • Notice possible changes of behavior
  • Explain the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi

Notice Possible Changes of Behavior (Reminder only for developers)

No response

Notice any changes of core modules (Reminder only for developers)

No response

Notice Possible Changes of Core Modules (Reminder only for developers)

No response

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Review and understand the proposed feature and its importance.
  • Research on the existing solutions and relevant research articles/resources.
  • Discuss with the team to evaluate the feasibility of implementing the feature.
  • Create a design document outlining the proposed solution and implementation details.
  • Get feedback from the team on the design document.
  • Develop the feature following the agreed design.
  • Write unit tests and integration tests for the feature.
  • Update the documentation to include the new feature.
  • Perform code review and address any issues.
  • Merge the feature into the main branch.
  • Monitor for any issues or bugs reported by users after the feature is released.
  • Address any issues or bugs reported by users and continuously improve the feature.
@hongriTianqi hongriTianqi added the Feature Discussed The features will be discussed first but will not be implemented soon label Nov 20, 2023
@hongriTianqi
Copy link
Author

This is related to #3130

@hongriTianqi
Copy link
Author

hongriTianqi commented Apr 11, 2024

Todos:

  • add test links on Force and Stress finite difference tests.
  • add case test for the functionality of new codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Discussed The features will be discussed first but will not be implemented soon
Projects
None yet
3 participants