Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: rename and privatize index mapping arrays in Parallel_2D; simplify deepks interfaces #2697

Merged
merged 5 commits into from Jul 15, 2023

Conversation

maki49
Copy link
Collaborator

@maki49 maki49 commented Jul 4, 2023

  • trace_loc_row -> global2local_row_ (the same with col)
  • row_set -> local2global_row_ (the same with col)
  • public to private, and add corresponding getters
  • simplify deepks interfaces

@dyzheng If any atoms/orbitals-related interfaces are needed, please add them into Parallel_Orbitals rather than Parallel_2D.

@maki49 maki49 force-pushed the refactor_parav branch 2 times, most recently from 954fd53 to ad5302b Compare July 6, 2023 09:19
@maki49 maki49 closed this Jul 6, 2023
@maki49 maki49 deleted the refactor_parav branch July 6, 2023 14:31
@maki49 maki49 reopened this Jul 6, 2023
@maki49 maki49 changed the title Refactor: rename index mapping arrays in Parallel_2D Refactor: rename and privatize index mapping arrays in Parallel_2D; simplify deepks interfaces Jul 6, 2023
@dyzheng dyzheng merged commit e79144f into deepmodeling:develop Jul 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants