-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the global variable reference in the file istate_charge.cpp #3065
Conversation
AsTonyshment
commented
Oct 15, 2023
- Change all global variables to function parameter inputs.
- Modified the file using the corresponding function.
Hello, could you please link this PR to one issue, in which considerations of this code change are introduced and explained? So that more maintainers can understand your PR quickly. Thanks! |
I think I have understood your PR, it is, decouple as much as possible functions with GlobalV. While I have no idea about evaluating this change. Use of GlobalC is rather needed to eliminate all over codes, but for GlobalV I am not sure. |
I am rather new to this project and still have a lot to learn about. I will take a view into your consideration as far as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have formatted the file esolver_ks_lcao_elec.cpp, it is hard to find which line changed actually.
@dyzheng Do you suggest not formatting the original file? |
I suggest to point out which line has been modified in this PR if the format of original file has been changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the directly using of global variable comply with ABACUS programming guidelines.
Thanks for your contribution!
Please fix the conflicts. |