Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: add values to hK rather than LM.Hloc in OperatorEXX::contribute_Hk #3322

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Refactor: add values to hK rather than LM.Hloc in OperatorEXX::contribute_Hk #3322

merged 1 commit into from
Dec 13, 2023

Conversation

maki49
Copy link
Collaborator

@maki49 maki49 commented Dec 9, 2023 •
edited

Some algorithms will need a custom hK passed into OperatorEXX, which should not be fixed to LM.Hloc(2).

dyzheng
dyzheng approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for replacing old code with new code.

@dyzheng dyzheng merged commit 68bf30a into deepmodeling:develop Dec 13, 2023
11 checks passed
@maki49 maki49 deleted the exx_hk branch April 17, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyzheng dyzheng dyzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maki49 @dyzheng