-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Fix convergence problem of spin-polarized metaGGA calculation for nspin=2 #3328
Bug: Fix convergence problem of spin-polarized metaGGA calculation for nspin=2 #3328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, undefined behavior(s) eliminated
I've test the performance of this repository on Fe-bcc and C-diamond system, which both have good convergence performance. For C-diamond, the TMAG and AMAG after converge to For Fe-bcc, if One more thing to notice is that if I set
And |
I will realize a new mixing method for tau, which maybe improve convergence for metaGGA. After that, we can double-check if these confusions are still there. |
Fix #3260 and #3146, in which scan calculation.
What's changed?
psiToRho()
mix_rho()
set_mixing()
andmix_reset()
After this PR, convergence problem of spin-polarized metaGGA calculation is almost solved.