Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: wrong override in veff_lcao, and some error annotations #3367

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix: wrong override in veff_lcao, and some error annotations #3367

merged 1 commit into from
Dec 22, 2023

Conversation

dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Dec 21, 2023 •
edited

What's changed?

  • Fix the wrong function Veff<OperatorLCAO<TK, TR>>::contributeHK(), the correct function for this derivative class is OperatorLCAO<TK, TR>::contributeHK() after this PR.
  • Fix incorrect annotations for HContainer since last feature changes.

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@dyzheng dyzheng linked an issue Dec 22, 2023 that may be closed by this pull request
New tools in container module HContainer #3161
Closed
14 tasks
WHUweiqingzhou
WHUweiqingzhou approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@WHUweiqingzhou WHUweiqingzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!

@WHUweiqingzhou WHUweiqingzhou merged commit e7c367d into deepmodeling:develop Dec 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WHUweiqingzhou WHUweiqingzhou WHUweiqingzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New tools in container module HContainer
2 participants
@dyzheng @WHUweiqingzhou