Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify the reference of 184_PW_BNDKPAR_SDFT_MALL/ALL #3369

Merged
merged 1 commit into from
Dec 22, 2023
Merged

modify the reference of 184_PW_BNDKPAR_SDFT_MALL/ALL #3369

merged 1 commit into from
Dec 22, 2023

Conversation

pxlxingliang
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Since #3175 modify the symmetry_prec from 1e-5 to 1e-6, 184_PW_BNDKPAR_SDFT_ALL/184_PW_BNDKPAR_SDFT_MALL will suffer warning.
Modify the reference to the value produced by latest codes.

Linked Issue

Fix #3242

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@pxlxingliang pxlxingliang mentioned this pull request Dec 22, 2023
Open
60 tasks
dyzheng
dyzheng approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the change of references, but please pay attention to performance.

tests/integrate/184_PW_BNDKPAR_SDFT_ALL/result.ref Show resolved Hide resolved
@dyzheng dyzheng merged commit e76d2a0 into deepmodeling:develop Dec 22, 2023
11 checks passed
@pxlxingliang pxlxingliang deleted the tests branch January 5, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyzheng dyzheng dyzheng approved these changes

@Qianruipku Qianruipku Awaiting requested review from Qianruipku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attention should be paid to some certain PR during integrated testing as they may pose some warning.
2 participants
@pxlxingliang @dyzheng