forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor&Feature: add default value controlling decimal length of output for out_mat_hs 1
case and expose user control keyword out_ndigits
#3377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHUweiqingzhou
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces a new parameter out_ndigits
, which can tune the precision of output. This parameter only supports the output of Hamil and overlap currently. Thanks for your valuable effort.
YuLiu98
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The precision loss of output is a large problem for any postprocessing, also for restarting tasks. When I print out Hamiltonian matrix and overlap, also wavefunctions, I find wavefunctions' orthonormalities are quite poor if I calculate
psi@S@psi.conj().T
withnumpy
directly, this is because of loss of numerical precision when outputting H and S matrix.There is also other user @QG-phy mention the low efficiency of restarting SCF from a converged, output charge density and has addressed the problem raises from the lack of output precision control.
The formatting of output will be a relatively long-term task because there are many output files, we need to refactor them with formatter library one-by-one.
It is also a pre-requisite of implementation of QO, PR #3236
Results
In
INPUT
, write:Then find files in OUT.${suffix} directory:
Reminder
Linked Issue
Fix #3373
What's changed?
out_ndigits
to control the output precision, default is 8.Any changes of core modules? (ignore if not applicable)