Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: add precision tests for zeros and derivatives in math sphbes #3445

Merged
merged 2 commits into from Jan 12, 2024

Conversation

jieli-matrix
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@jieli-matrix
Copy link
Collaborator Author

I add precision tests for zeros and derivatives in math sphbes as we mentioned in #3361. I was wondering if more data points should be added into tests. Besides, TEST_F(Sphbes, DerivativesOld) haven't met the precision threshold(set as 1e-14) at some points, and I paste related outputs here:

l = 3, r = 2, errs = 8.87874e-12
l = 3, r = 4, errs = 5.42921e-13
l = 3, r = 8, errs = 1.40672e-14
l = 4, r = 1, errs = 1.38778e-06
l = 4, r = 2, errs = 4.33681e-08
l = 4, r = 8, errs = 4.23517e-11
l = 4, r = 16, errs = 1.32305e-12
l = 5, r = 1, errs = 2.77556e-10
l = 5, r = 2, errs = 1.73472e-11
l = 5, r = 8, errs = 6.77627e-14

cc: @jinzx10

Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyzheng dyzheng merged commit 8a969c7 into deepmodeling:develop Jan 12, 2024
11 checks passed
@jieli-matrix jieli-matrix deleted the jie-precision branch March 1, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants