Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Removed GlobalVs related to module_io/istate_envelope.cpp #3801

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Refactor: Removed GlobalVs related to module_io/istate_envelope.cpp #3801

merged 4 commits into from
Mar 26, 2024

Conversation

AsTonyshment
Copy link
Collaborator

@AsTonyshment AsTonyshment commented Mar 25, 2024 •
edited
Loading

What's changed?

Removed GlobalVs related to module_io/istate_envelope.cpp, including:

  • GlobalV::nelec
  • GlobalV::NBANDS_ISTATE
  • GlobalV::NBANDS
  • GlobalV::NSPIN
  • GlobalV::NLOCAL
  • GlobalV::global_out_dir

Related to Issue #3806.

@mohanchen mohanchen merged commit 869929a into deepmodeling:develop Mar 26, 2024
12 checks passed
@AsTonyshment AsTonyshment mentioned this pull request Mar 26, 2024
Open
8 tasks
@AsTonyshment AsTonyshment deleted the remove-globalv-istate branch June 17, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AsTonyshment @mohanchen