Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using STL std::vector replace new[] and delete[], in module_base/test/math_ylmreal_test.cpp #3974

Closed
wants to merge 4 commits into from

Conversation

yang2022i
Copy link

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@kirk0830 kirk0830 changed the title using [stl ve ctor] replace [new]and[delete], in "./source/module_base/test/math_ylmreal_test.cpp" using STL std::vector replace new[] and delete[], in module_base/test/math_ylmreal_test.cpp Apr 15, 2024
@mohanchen
Copy link
Collaborator

Since no further updates, I will close this PR

@mohanchen mohanchen closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants