Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: memory leak in tddft #4012

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Fix: memory leak in tddft #4012

merged 3 commits into from
Apr 18, 2024

Conversation

caic99
Copy link
Member

@caic99 caic99 commented Apr 17, 2024 •
edited
Loading

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #3553

WHUweiqingzhou
WHUweiqingzhou approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@WHUweiqingzhou WHUweiqingzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WHUweiqingzhou WHUweiqingzhou merged commit 277e92d into deepmodeling:develop Apr 18, 2024
12 checks passed
@caic99 caic99 deleted the fix-mem-leak branch April 18, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WHUweiqingzhou WHUweiqingzhou WHUweiqingzhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There are memory leaks in a series of case tests
2 participants
@caic99 @WHUweiqingzhou