Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add device error check for functions within device.cpp #4106

Merged
merged 1 commit into from
May 7, 2024
Merged

Feature: add device error check for functions within device.cpp #4106

merged 1 commit into from
May 7, 2024

Conversation

denghuilu
Copy link
Member

@denghuilu denghuilu commented May 6, 2024 •
edited
Loading

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

May related to #4062.

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@denghuilu denghuilu mentioned this pull request May 6, 2024
Closed
16 tasks
haozhihan
haozhihan approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@haozhihan haozhihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haozhihan haozhihan requested a review from caic99 May 6, 2024 15:07
@caic99 caic99 linked an issue May 7, 2024 that may be closed by this pull request
Error when using bohrium B series GPU. #4062
Closed
16 tasks
@haozhihan haozhihan merged commit d0f69c2 into deepmodeling:develop May 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haozhihan haozhihan haozhihan approved these changes

@caic99 caic99 caic99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using bohrium B series GPU.
3 participants
@denghuilu @haozhihan @caic99