Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: optimize cast_memory_op #4160

Merged
merged 5 commits into from
May 22, 2024
Merged

Refactor: optimize cast_memory_op #4160

merged 5 commits into from
May 22, 2024

Conversation

denghuilu
Copy link
Member

@denghuilu denghuilu commented May 13, 2024 •
edited by caic99

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

#4153
Related to #4154

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@denghuilu denghuilu requested a review from caic99 May 13, 2024 08:33
@mohanchen
Copy link
Collaborator

no issue linked

@denghuilu
Copy link
Member Author

Related to #4153

@denghuilu denghuilu linked an issue May 15, 2024 that may be closed by this pull request
Double peak memory cost in cast_memory_op #4153
Closed
16 tasks
@mohanchen mohanchen merged commit 8f93b78 into deepmodeling:develop May 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

@caic99 caic99 caic99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double peak memory cost in cast_memory_op
3 participants
@denghuilu @mohanchen @caic99