Refactor: remove paw code in module_hsolver #4182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder
Linked Issue
Fix #4180
Details
The abacus develop team is executing @mohanchen's Absolute Zero plan to refactor the code of different modules.
Currently, I am responsible for the refactoring of module_hsolver.
As far as I know, currently there are no users using the paw-related functions in abacus. Therefore, @mohanchen recommends deleting the paw-related code when refactoring and creating a new paw_code branch to save the current paw-related code.
After waiting for the refactoring plan to go well, consider adding the paw code.
I have created a new paw_code branch, and I submit this PR to delete the paw-related code in module_hsolver.