Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulation of K_point modules #4240

Merged
merged 30 commits into from
May 31, 2024
Merged

Encapsulation of K_point modules #4240

merged 30 commits into from
May 31, 2024

Conversation

jwsyzy
Copy link

@jwsyzy jwsyzy commented May 26, 2024 •
edited
Loading

What's changed?

  • Move ::nks,nkstot,nkstot_ibz,nkstot_full:: to private
  • Add related functions to set and get the above variables
  • Add annotation to klist.cpp and klist.h

mohanchen
mohanchen reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some replacements seem unreasonable

replace_nks.sh Outdated Show resolved Hide resolved
source/module_cell/test/klist_test.cpp Outdated Show resolved Hide resolved
@mohanchen mohanchen merged commit 24ee311 into deepmodeling:develop May 31, 2024
13 checks passed
@mohanchen mohanchen added the Refactor Refactor ABACUS codes label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
Refactor Refactor ABACUS codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwsyzy @mohanchen @ChaoxiWXR