Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : printing initial charge density #4254

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

wenfei-li
Copy link

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@wenfei-li wenfei-li linked an issue May 28, 2024 that may be closed by this pull request
14 tasks
@WHUweiqingzhou
Copy link
Collaborator

@wenfei-li,
I notice this PR has not been updated for while, any help needed?

@wenfei-li
Copy link
Author

wenfei-li commented Jun 6, 2024

@wenfei-li, I notice this PR has not been updated for while, any help needed?

This pr is finished work. I do not think it needs any further update or modification.

Copy link
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The developer won't follow instructions, but I will merge it. P. S. Further modifications of this PR by other developers will be expected.

@mohanchen mohanchen merged commit 69db5c6 into deepmodeling:develop Jun 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outputting initial charge density and potential
3 participants