forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and Remove some functions in klist.h etc #4257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nice job, I will discuss with you about the PR proposed by another group. |
kirk0830
requested changes
Jun 7, 2024
kirk0830
approved these changes
Jun 7, 2024
mohanchen
approved these changes
Jun 8, 2024
mohanchen
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's part of the final class project.
What's changed?
set_both_kvec_after_vc
for it do the same asset_after_vc
set_after_vc
K_Vectors::mpi_k_after_vc
for it do the same asmpi_k
set_kup_and_kdw_after_vc
for it's useless nowLinely_add_k_between
to make the funcread_kpoints
more readablepool_collection_aux
to deal with the repeat ofpool_collection
ibz2bz
to privatedoxygen
and modify the code indentation formatsymm.equal(a.e32, b.e32)
inauto matequal
Thanks to kirk0830's suggestions, more changes were made as follows:
ofstream& ofs
to take place ofGlobalV::ofs_running
in funcset
if-else
s ofnspin
clearermax_kpoints