Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: delete GlobalV::CURRENT_SPIN in code #4301

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Refactor: delete GlobalV::CURRENT_SPIN in code #4301

merged 2 commits into from
Jun 4, 2024

Conversation

dyzheng
Copy link
Collaborator

@dyzheng dyzheng commented Jun 3, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4300

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@dyzheng dyzheng requested a review from mohanchen June 4, 2024 01:22
@mohanchen mohanchen merged commit 7c5a670 into deepmodeling:develop Jun 4, 2024
13 checks passed
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: I will remove GlobalV::CURRENT_SPIN in ABACUS
2 participants
@dyzheng @mohanchen