Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: accelerate integrate tests #4358

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Conversation

YuLiu98
Copy link
Collaborator

@YuLiu98 YuLiu98 commented Jun 13, 2024

Linked Issue

Fix #4357

@YuLiu98 YuLiu98 requested a review from mohanchen June 13, 2024 00:59
@mohanchen mohanchen added the Compile & CICD & Docs Issues related to compiling ABACUS label Jun 13, 2024
Copy link
Collaborator

@WHUweiqingzhou WHUweiqingzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find some warnings in CI tests for the cases you update the ref data in this PR, which confuses me. f.e:
103_PW_15_CF_CS_S1_smallg
103_PW_15_CF_CS_S2_smallg
601_NO_TDDFT_CO
601_NO_TDDFT_CO_occ

I do not list all of them here. How do you get the ref data?
According to https://github.com/deepmodeling/abacus-develop/blob/develop/.github/workflows/test.yml and https://github.com/deepmodeling/abacus-develop/blob/develop/tests/integrate/CMakeLists.txt,
I believe CI test uses OMP_NUM_THREADS=2 mpirun -np 4 abacus |tee log to get result.

@YuLiu98
Copy link
Collaborator Author

YuLiu98 commented Jun 14, 2024

I find some warnings in CI tests for the cases you update the ref data in this PR, which confuses me. f.e: 103_PW_15_CF_CS_S1_smallg 103_PW_15_CF_CS_S2_smallg 601_NO_TDDFT_CO 601_NO_TDDFT_CO_occ

I do not list all of them here. How do you get the ref data? According to https://github.com/deepmodeling/abacus-develop/blob/develop/.github/workflows/test.yml and https://github.com/deepmodeling/abacus-develop/blob/develop/tests/integrate/CMakeLists.txt, I believe CI test uses OMP_NUM_THREADS=2 mpirun -np 4 abacus |tee log to get result.

Note that the original CI test reports 65 warnings, while this PR's CI test reports 48 warnings. I have reduced some warnings except for 601_NO_TDDFT_CO_occ. As I know from @lyb9812, this TDDFT example is unstable.

@WHUweiqingzhou
Copy link
Collaborator

I find some warnings in CI tests for the cases you update the ref data in this PR, which confuses me. f.e: 103_PW_15_CF_CS_S1_smallg 103_PW_15_CF_CS_S2_smallg 601_NO_TDDFT_CO 601_NO_TDDFT_CO_occ
I do not list all of them here. How do you get the ref data? According to https://github.com/deepmodeling/abacus-develop/blob/develop/.github/workflows/test.yml and https://github.com/deepmodeling/abacus-develop/blob/develop/tests/integrate/CMakeLists.txt, I believe CI test uses OMP_NUM_THREADS=2 mpirun -np 4 abacus |tee log to get result.

Note that the original CI test reports 65 warnings, while this PR's CI test reports 48 warnings. I have reduced some warnings except for 601_NO_TDDFT_CO_occ. As I know from @lyb9812, this TDDFT example is unstable.

how about these cases?
103_PW_15_CF_CS_S1_smallg
103_PW_15_CF_CS_S2_smallg
601_NO_TDDFT_CO

@YuLiu98
Copy link
Collaborator Author

YuLiu98 commented Jun 14, 2024

I find some warnings in CI tests for the cases you update the ref data in this PR, which confuses me. f.e: 103_PW_15_CF_CS_S1_smallg 103_PW_15_CF_CS_S2_smallg 601_NO_TDDFT_CO 601_NO_TDDFT_CO_occ
I do not list all of them here. How do you get the ref data? According to https://github.com/deepmodeling/abacus-develop/blob/develop/.github/workflows/test.yml and https://github.com/deepmodeling/abacus-develop/blob/develop/tests/integrate/CMakeLists.txt, I believe CI test uses OMP_NUM_THREADS=2 mpirun -np 4 abacus |tee log to get result.

Note that the original CI test reports 65 warnings, while this PR's CI test reports 48 warnings. I have reduced some warnings except for 601_NO_TDDFT_CO_occ. As I know from @lyb9812, this TDDFT example is unstable.

how about these cases? 103_PW_15_CF_CS_S1_smallg 103_PW_15_CF_CS_S2_smallg 601_NO_TDDFT_CO

As I mentioned above, these tests already reported warnings before this PR. Maybe previous PRs should be checked to determine when these warnings are introduced.

103_PW_15_CF_CS_S1_smallg and 103_PW_15_CF_CS_S1_smallg do not report warnings after this PR.

Copy link
Collaborator

@WHUweiqingzhou WHUweiqingzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mohanchen mohanchen merged commit f16c4a7 into deepmodeling:develop Jun 15, 2024
13 checks passed
@maki49 maki49 mentioned this pull request Jul 2, 2024
@YuLiu98 YuLiu98 deleted the test branch July 13, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compile & CICD & Docs Issues related to compiling ABACUS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running integration tests is too time-consuming
4 participants