Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: replace pointer to Diago classes with object #4409

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Refactor: replace pointer to Diago classes with object #4409

merged 3 commits into from
Jun 18, 2024

Conversation

Cstandardlib
Copy link
Collaborator

Linked Issue

#4373

What's changed?

  • Replace pointer with object instance for cg & bpcg & david in module_hsolver/hsolver_pw.cpp

@mohanchen mohanchen merged commit 2df0dc2 into deepmodeling:develop Jun 18, 2024
13 checks passed
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jun 22, 2024
@Cstandardlib Cstandardlib deleted the refactor-remove-pdiagh branch June 22, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

@dyzheng dyzheng dyzheng left review comments

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Cstandardlib @mohanchen @dyzheng