Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the useless variables and functions in unkOverlap_lcao #4569

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

pxlxingliang
Copy link
Collaborator

@pxlxingliang pxlxingliang commented Jul 4, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #4570

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Jul 4, 2024
@mohanchen mohanchen merged commit 4f4a050 into deepmodeling:develop Jul 4, 2024
13 checks passed
@pxlxingliang pxlxingliang deleted the berry branch July 9, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: remove class Local_Orbital_Charge
2 participants