Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the memory problem in berryphase #4631

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: the memory problem in berryphase #4631

merged 1 commit into from
Jul 10, 2024

Conversation

pxlxingliang
Copy link
Collaborator

@pxlxingliang pxlxingliang commented Jul 10, 2024 •
edited by WHUweiqingzhou
Loading

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Related with #4628

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

@pxlxingliang pxlxingliang changed the title fix: the memory leak in berryphase fix: the memory problem in berryphase Jul 10, 2024
@mohanchen mohanchen merged commit 8009513 into deepmodeling:develop Jul 10, 2024
13 checks passed
@mohanchen mohanchen added the Bug Report (Exclude input and output) Bugs that only solvable with sufficient knowledge of DFT label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

@Qianruipku Qianruipku Qianruipku approved these changes

Assignees
No one assigned
Labels
Bug Report (Exclude input and output) Bugs that only solvable with sufficient knowledge of DFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pxlxingliang @mohanchen @Qianruipku