Skip to content

Commit

Permalink
chore: improve type checking (#62)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced type checking workflow for a Python package using GitHub
Actions.

- **Improvements**
- Enhanced type annotations across various modules for better code
clarity and maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
  • Loading branch information
njzjz committed May 17, 2024
1 parent 2a93b32 commit fc8cac4
Show file tree
Hide file tree
Showing 15 changed files with 167 additions and 108 deletions.
16 changes: 16 additions & 0 deletions .github/workflows/type-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Type check
on:
- push
- pull_request

jobs:
type_check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.12
- run: pip install uv
- run: uv run basedpyright --with .[typecheck]
2 changes: 2 additions & 0 deletions dargs/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

from .dargs import Argument, ArgumentEncoder, Variant

__all__ = ["Argument", "Variant", "ArgumentEncoder"]

0 comments on commit fc8cac4

Please sign in to comment.