Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_out_bias for linear atomic model #3586

Closed
github-actions bot opened this issue Mar 22, 2024 · 0 comments
Closed

add get_out_bias for linear atomic model #3586

github-actions bot opened this issue Mar 22, 2024 · 0 comments

Comments

@github-actions
Copy link

Line: 310

def get_out_bias(self) -> torch.Tensor:
"""Return the weighted output bias of the linear atomic model."""
# TODO add get_out_bias for linear atomic model
raise NotImplementedError
def get_dim_fparam(self) -> int:
"""Get the number (dimension) of frame parameters of this atomic model."""
# tricky...
return max([model.get_dim_fparam() for model in self.models])

github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2024
Refactor stat related methods in LinearAtomicModel.
This should resolve #3585 #3586 #3528

---------

Signed-off-by: Anyang Peng <137014849+anyangml@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@anyangml anyangml closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant