Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give a clear message if model.get_ntypes()<data.get_ntypes() #1016

Merged
merged 1 commit into from
Aug 23, 2021
Merged

give a clear message if model.get_ntypes()<data.get_ntypes() #1016

merged 1 commit into from
Aug 23, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Aug 22, 2021 •
edited
Loading

Fix #1015.

image

@njzjz njzjz changed the base branch from master to devel August 22, 2021 21:11
@njzjz njzjz changed the title ntypes not enough give a clear message if model.get_ntypes()<data.get_ntypes() Aug 22, 2021
@njzjz njzjz linked an issue Aug 22, 2021 that may be closed by this pull request
Training A-B potential with different datasets(A, B, and AB) #1015
Closed
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021 •
edited
Loading

Codecov Report

Merging #1016 (8f57fb3) into devel (d42ca99) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1016      +/-   ##
==========================================
- Coverage   75.02%   75.01%   -0.02%     
==========================================
  Files          86       86              
  Lines        6923     6924       +1     
==========================================
  Hits         5194     5194              
- Misses       1729     1730       +1
Impacted Files Coverage Δ
deepmd/train/trainer.py 70.06% <50.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42ca99...8f57fb3. Read the comment docs.

@amcadmus amcadmus merged commit a1a97fe into deepmodeling:devel Aug 23, 2021
@njzjz njzjz deleted the ntypes_not_enough branch August 25, 2021 04:27
gzq942560379 pushed a commit to HPC-AI-Team/deepmd-kit that referenced this pull request Sep 2, 2021
@njzjz
give a clear message if model.get_ntypes()<data.get_ntypes() (deepm…
84fb302 
…odeling#1016)

Fix deepmodeling#1015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcadmus amcadmus amcadmus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@njzjz @codecov-commenter @amcadmus