Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix device UT error #1056

Merged
merged 2 commits into from Aug 29, 2021
Merged

fix device UT error #1056

merged 2 commits into from Aug 29, 2021

Conversation

denghuilu
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #1056 (6b8910a) into devel (a7e4760) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1056      +/-   ##
==========================================
+ Coverage   75.10%   75.17%   +0.07%     
==========================================
  Files          87       87              
  Lines        6953     6953              
==========================================
+ Hits         5222     5227       +5     
+ Misses       1731     1726       -5     
Impacted Files Coverage Δ
deepmd/utils/data_system.py 71.60% <0.00%> (+0.24%) ⬆️
deepmd/utils/data.py 91.25% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e4760...6b8910a. Read the comment docs.

Copy link
Contributor

@galeselee galeselee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on ROCm platform. . The results showed that there are 23 skipped.
'''
Ran 265 tests in 974.050s
OK (skipped=23)
'''
is that normal?

@denghuilu
Copy link
Member Author

I tested it on ROCm platform. . The results showed that there are 23 skipped.

'''

Ran 265 tests in 974.050s

OK (skipped=23)

'''

is that normal?

The same as cpu and gpu.

@galeselee
Copy link
Contributor

I tested it on ROCm platform. . The results showed that there are 23 skipped.
'''
Ran 265 tests in 974.050s
OK (skipped=23)
'''
is that normal?

The same as cpu and gpu.

But why did the test skip

@amcadmus
Copy link
Member

I tested it on ROCm platform. . The results showed that there are 23 skipped.
'''
Ran 265 tests in 974.050s
OK (skipped=23)
'''
is that normal?

The same as cpu and gpu.

But why did the test skip

Skipped when the tf version is not satisfied with the UT. see

@unittest.skipIf(parse_version(tf.__version__) < parse_version("1.15"),

@amcadmus amcadmus merged commit 8dbc211 into deepmodeling:devel Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants