use np.testing.assert_almost_equal for array comparing
#1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #1059 +/- ##
===========================================
- Coverage 75.16% 64.28% -10.89%
===========================================
Files 87 5 -82
Lines 6959 14 -6945
===========================================
- Hits 5231 9 -5222
+ Misses 1728 5 -1723 Continue to review full report at Codecov.
|
njzjz
commented
Aug 29, 2021
| dp_random.seed(0) | ||
| data2 = DeepmdDataSystem(['system_0', 'system_1'], | ||
| 5, | ||
| 10, | ||
| 1.0) | ||
| data2.add('force', 3, atomic = True, must = True) | ||
| data2.add('energy', 1, must = True) |
There was a problem hiding this comment.
The original data1 and data2 are not equal - but the original compare method didn't find it...
I'm not sure what's the purpose of this test case?
There was a problem hiding this comment.
This should be a bug in the UT...
amcadmus
approved these changes
Aug 29, 2021
denghuilu
approved these changes
Aug 30, 2021
amcadmus
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comment below.