upgrade os.system to subporcess.popen method #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #1066 +/- ##
=======================================
Coverage 75.16% 75.16%
=======================================
Files 87 87
Lines 6959 6959
=======================================
Hits 5231 5231
Misses 1728 1728 Continue to review full report at Codecov.
|
njzjz
reviewed
Aug 30, 2021
| @@ -17,6 +18,16 @@ def _file_delete(file) : | |||
| if os.path.exists(file): | |||
| os.remove(file) | |||
|
|
|||
| def _subprocess_run(command): | |||
| popen = sp.Popen(command, shell=True, stdout=sp.PIPE, stderr=sp.STDOUT) | |||
There was a problem hiding this comment.
I prefer setting shell to False and using command.split() instead of command. Using a shell is not safe.
njzjz
approved these changes
Aug 30, 2021
amcadmus
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the os.system to subporcess.popen method. According to the doc of os.system method:
In general,
subprocess.Popen()is super-set ofos.system().