Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Fail to build on macos: explicit instantiation of 'deepmd::Region' must occur in namespace 'deepmd' #1071

Merged
merged 1 commit into from Aug 31, 2021

Conversation

amcadmus
Copy link
Member

No description provided.

@amcadmus amcadmus requested a review from njzjz August 31, 2021 02:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #1071 (fd81a53) into devel (a7e4760) will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1071      +/-   ##
==========================================
- Coverage   75.10%   74.42%   -0.69%     
==========================================
  Files          87       87              
  Lines        6953     6943      -10     
==========================================
- Hits         5222     5167      -55     
- Misses       1731     1776      +45     
Impacted Files Coverage Δ
deepmd/infer/deep_tensor.py 56.09% <0.00%> (-39.03%) ⬇️
source/op/_gelu.py 71.42% <0.00%> (-6.35%) ⬇️
deepmd/entrypoints/freeze.py 73.58% <0.00%> (-0.89%) ⬇️
deepmd/train/run_options.py 71.42% <0.00%> (-0.27%) ⬇️
deepmd/loss/ener.py 47.34% <0.00%> (-0.24%) ⬇️
deepmd/train/trainer.py 70.54% <0.00%> (-0.14%) ⬇️
source/op/_tabulate_grad.py 100.00% <0.00%> (ø)
source/op/_prod_force_grad.py 100.00% <0.00%> (ø)
source/op/_prod_virial_grad.py 100.00% <0.00%> (ø)
source/op/_soft_min_force_grad.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7e4760...fd81a53. Read the comment docs.

Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it works.

@amcadmus amcadmus merged commit 75160c7 into deepmodeling:devel Aug 31, 2021
@amcadmus amcadmus deleted the fix-1070 branch September 8, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants