Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Python bugs of loc_frame descriptor #1253

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Oct 29, 2021

Fix #1248 (only the first part).

@njzjz njzjz requested a review from amcadmus October 29, 2021 06:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #1253 (357ac33) into devel (d57a53a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel    #1253   +/-   ##
=======================================
  Coverage   75.97%   75.98%           
=======================================
  Files          91       91           
  Lines        7402     7404    +2     
=======================================
+ Hits         5624     5626    +2     
  Misses       1778     1778           
Impacted Files Coverage Δ
deepmd/descriptor/loc_frame.py 97.63% <100.00%> (+0.01%) ⬆️
deepmd/entrypoints/train.py 87.64% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a53a...357ac33. Read the comment docs.

@wanghan-iapcm wanghan-iapcm merged commit 0362659 into deepmodeling:devel Oct 30, 2021
@njzjz njzjz deleted the loc_frame branch October 30, 2021 02:12
@njzjz njzjz linked an issue Jan 2, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

loc_frame support in v2.0.3
3 participants