Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of loc_frame descriptor when using lammps #1255

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

amcadmus
Copy link
Member

this bug is introduced by the the changed convention of neighbor list storage in v2

@amcadmus amcadmus requested a review from njzjz October 31, 2021 15:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #1255 (639fafa) into devel (0362659) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel    #1255   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files          91       91           
  Lines        7404     7404           
=======================================
  Hits         5626     5626           
  Misses       1778     1778           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0362659...639fafa. Read the comment docs.

@amcadmus amcadmus merged commit 09d1391 into deepmodeling:devel Nov 2, 2021
@amcadmus amcadmus deleted the fix-loc-frame branch November 22, 2021 00:53
@njzjz njzjz linked an issue Jan 2, 2022 that may be closed by this pull request
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Sep 21, 2023
The current `try...catch` does not report what's wrong in the YAML file
if it is invalid.

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

loc_frame support in v2.0.3
3 participants